| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Doubled test for SET statements in pg_stat_statements tests |
| Date: | 2023-11-08 07:33:23 |
| Message-ID: | 5689421699428803@mail-sendbernar-production-main-46.myt.yp-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello!
I noticed that the same block
-- SET statements.
-- These use two different strings, still they count as one entry.
SET work_mem = '1MB';
Set work_mem = '1MB';
SET work_mem = '2MB';
RESET work_mem;
SET enable_seqscan = off;
SET enable_seqscan = on;
RESET enable_seqscan;
is checked twice in contrib/pg_stat_statements/sql/utility.sql on lines 278-286 and 333-341. Is this on any purpose? I think the second set of tests is not needed and can be removed, as in the attached patch.
regards, Sergei
| Attachment | Content-Type | Size |
|---|---|---|
| pgss_doubled_test_for_set_statements.patch | text/x-diff | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-11-08 07:34:37 | Re: Show WAL write and fsync stats in pg_stat_io |
| Previous Message | David Rowley | 2023-11-08 07:31:28 | Re: ensure, not insure |