Re: Doubled test for SET statements in pg_stat_statements tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sergei Kornilov <sk(at)zsrv(dot)org>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Doubled test for SET statements in pg_stat_statements tests
Date: 2023-11-09 03:58:04
Message-ID: ZUxYzP1SOyiEfK4G@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 08, 2023 at 10:33:23AM +0300, Sergei Kornilov wrote:
> is checked twice in contrib/pg_stat_statements/sql/utility.sql on
> lines 278-286 and 333-341. Is this on any purpose? I think the
> second set of tests is not needed and can be removed, as in the
> attached patch.

Thanks, applied. This looks like a copy-paste mistake coming from
de2aca288569, even if it has added more scenarios for patterns around
SET.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-11-09 04:01:09 Re: Parallel query behaving different with custom GUCs
Previous Message Amit Kapila 2023-11-09 03:25:53 Re: Synchronizing slots from primary to standby