From: | Amir Rohan <amir(dot)rohan(at)zoho(dot)com> |
---|---|
To: | PostgreSQL www <pgsql-www(at)postgresql(dot)org> |
Cc: | Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, "magnus(at)hagander(dot)net" <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: PATCH: Add "mail me this message" feature to archive viewer |
Date: | 2015-11-07 12:14:52 |
Message-ID: | 563DEB3C.2000706@zoho.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
On 10/12/2015 04:56 PM, Amir Rohan wrote:
> Hi,
>
> See attached patch implementing this feature, as discussed in the
> "No easy way to join existing discussion when not subscribed" thread
> <56138D2D(dot)1000304(at)zoho(dot)com>.
> As my troublesome mail client turned that thread into a mess, this
> should server as a fresh start.
>
> The patch adds a "via email" link beside "[raw] or [whole thread]"
> in the message view. A Mailqueue implementation was copied verbatim
> from pgweb and so the mail worker at
> `tools/mailqueue/send_queued_mail.py` needs to run periodically to drain
> the queue.
>
>
> It was agreed that restricting this feature to logged-in community users
> was necessary and sufficient, so I have added the necessary decorators
> to the view. Because the archive app isn't currently
> hooked in to the community login system, and because I cannot fix that
> without aid from the web team, they are currently commented out.
>
> Optional patch 0002 uses django's "flash" messages extension to provide
> visual feedback to the user using a very soothing shade of green.
>
> Screenshot: http://bit.ly/1R71P6U
>
On 10/21/2015 04:51 PM, Amir Rohan wrote:
> Bump. Is there something more I can do to get this live on the
> archives?
> I've wanted to actually make use of this several times since
> implementing it.
On 10/21/2015 05:21 PM, Stephen Frost wrote:
> I'm afraid that we're currently waiting on Magnus to have time to
> formally review the changes, which is unlikely to happen this week or
> next as he's heavily involved in the PGConf.EU conference.
Bump. Still waiting for help from the web team to implement community
auth in the archives app in order to get this on the website.
Amir
From | Date | Subject | |
---|---|---|---|
Next Message | Amir Rohan | 2015-11-07 12:16:53 | Re: pgarchives: strip angle brackets when checking for msgid search |
Previous Message | Umair Shahid | 2015-11-06 17:25:22 | Introducing 2UDA, 2ndQuadrant’s Unified Data Analytics |