Re: pgarchives: strip angle brackets when checking for msgid search

From: Amir Rohan <amir(dot)rohan(at)zoho(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL www <pgsql-www(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: pgarchives: strip angle brackets when checking for msgid search
Date: 2015-11-07 12:16:53
Message-ID: 563DEBB5.5070205@zoho.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On 10/21/2015 04:49 PM, Amir Rohan wrote:
> On 10/05/2015 04:01 PM, Amir Rohan wrote:
>> On 10/05/2015 11:57 AM, Magnus Hagander wrote:
>>>
>>> So either the API needs to be updated to return the actual URL, and the
>>> consumers (which at this point I believe are just the main website) need
>>> to be updated to actually use that URL, or the consumer also needs to be
>>> updated with the same "cleaning" rules, or the URL parsing in the
>>> archives code need to also deal with all those cases.
>>>
>>> I think either the first, or a combination of first and third, of those
>>> are the way to go. The second one (doing the same changes in the pgweb
>>> code) seems to just put us in a position where we'll make the same
>>> mistake again next time we try to fix these rules.
>>>
>>
>> With these patches <...>
>
> Bump. Magnus, is there something more I can do to get this on live
> on postgresql.org?
>

Bump. Waiting for feedback on the revised patch.

Amir

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Umair Shahid 2015-11-10 18:12:24 Re: Introducing 2UDA, 2ndQuadrant’s Unified Data Analytics
Previous Message Amir Rohan 2015-11-07 12:14:52 Re: PATCH: Add "mail me this message" feature to archive viewer