| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-20 18:00:50 |
| Message-ID: | 4F3B4B73-280F-4BAD-B1CC-BB11D9D6D92C@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 20 Dec 2023, at 18:22, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 2023-12-20 We 11:32, Robert Haas wrote:
>> On Wed, Dec 20, 2023 at 11:03 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>> This could perhaps be related to this patch removing the module in
>>>> src/tools/msvc/dummylib/Win32/Registry.pm ?
>>> It is. I've fixed the buildfarm to stop checking this script.
>> Thanks! But I wonder whether the script itself also needs to be
>> changed? Are we expecting that the 'use Win32::Registry' in
>> win32tzlist.pl would be satisfied externally in some case?
>
> Yes, the module will normally be present on a Windows perl. The only reason we had dummylib was so we could check the perl scripts on Unix.
Thanks for taking care of it!
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-12-20 19:09:06 | Re: index prefetching |
| Previous Message | Tom Lane | 2023-12-20 17:39:05 | Re: Estimation rows of FULL JOIN |