Re: Remove MSVC scripts from the tree

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove MSVC scripts from the tree
Date: 2023-12-20 17:22:42
Message-ID: f2efe477-e6db-5441-4f05-5992399a1c4a@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-12-20 We 11:32, Robert Haas wrote:
> On Wed, Dec 20, 2023 at 11:03 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> This could perhaps be related to this patch removing the module in
>>> src/tools/msvc/dummylib/Win32/Registry.pm ?
>> It is. I've fixed the buildfarm to stop checking this script.
> Thanks! But I wonder whether the script itself also needs to be
> changed? Are we expecting that the 'use Win32::Registry' in
> win32tzlist.pl would be satisfied externally in some case?
>

Yes, the module will normally be present on a Windows perl. The only
reason we had dummylib was so we could check the perl scripts on Unix.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Danil Anisimow 2023-12-20 17:31:51 Estimation rows of FULL JOIN
Previous Message David Steele 2023-12-20 17:11:37 Re: Detecting some cases of missing backup_label