Re: Estimation rows of FULL JOIN

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Danil Anisimow <anisimow(dot)d(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Estimation rows of FULL JOIN
Date: 2023-12-20 17:39:05
Message-ID: 338765.1703093945@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Danil Anisimow <anisimow(dot)d(at)gmail(dot)com> writes:
> In some cases, the planner underestimates FULL JOIN.

Perhaps.

> Are these simple changes enough to improve this situation?

This looks like an entirely ad-hoc change, one that could make as
many cases worse as it makes better. If you want to argue for
merging it, you at least need to provide some evidence for thinking
it's a more accurate model of what will happen. And adjust the
nearby comment to explain it.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-12-20 18:00:50 Re: Remove MSVC scripts from the tree
Previous Message Danil Anisimow 2023-12-20 17:31:51 Estimation rows of FULL JOIN