Re: ecpg tests broken by pgindent run

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ecpg tests broken by pgindent run
Date: 2010-02-26 17:23:54
Message-ID: 4B8803AA.4000909@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
>>>>
>>>>
>>> Don't look further, interfaces/ecpg/include/sqlda.h has changed
>>> by the pgindent run.
>>>
>> Yea, it is that, and sqltypes.h and one other file I am trying to find
>> now.
>>
>
> I have reverted changes to three include files who's output appears in
> the regression tests. I asssume this is new 9.0 behavior because I
> didn't have this issue before. I also updated the pgindent script to
> prevent these from being changed in the future.
>
>

Should not the instructions include doing a full set of regression tests
to ensure that nothing breaks? The new installcheck-world target should
help there.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2010-02-26 17:39:31 Re: pgbouncer + psql 9.0a4
Previous Message Garick Hamlin 2010-02-26 17:23:43 Re: pgbouncer + psql 9.0a4