From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Meskes <meskes(at)postgresql(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: ecpg tests broken by pgindent run |
Date: | 2010-02-26 17:09:23 |
Message-ID: | 201002261709.o1QH9NI04935@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bruce Momjian wrote:
> Boszormenyi Zoltan wrote:
> > > but if I look at the CVS history for
> > > /cvsroot/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c
> > > I see the last change was January 6, not from pgindent.
> > >
> > > My only guess is that there was some boilerplate code in the ecpg C
> > > files or outside /test which changed when ran pgindent.
> > >
> > > I am researching now.
> > >
> >
> > Don't look further, interfaces/ecpg/include/sqlda.h has changed
> > by the pgindent run.
>
> Yea, it is that, and sqltypes.h and one other file I am trying to find
> now.
I have reverted changes to three include files who's output appears in
the regression tests. I asssume this is new 9.0 behavior because I
didn't have this issue before. I also updated the pgindent script to
prevent these from being changed in the future.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/rtmp/diff | text/x-diff | 5.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Markus Wanner | 2010-02-26 17:18:03 | ProcSignalSlot vs. PGPROC |
Previous Message | Tom Lane | 2010-02-26 17:01:59 | Re: Avoiding bad prepared-statement plans. |