Re: ecpg tests broken by pgindent run

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ecpg tests broken by pgindent run
Date: 2010-02-26 18:00:22
Message-ID: 201002261800.o1QI0N818497@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
> >>>>
> >>>>
> >>> Don't look further, interfaces/ecpg/include/sqlda.h has changed
> >>> by the pgindent run.
> >>>
> >> Yea, it is that, and sqltypes.h and one other file I am trying to find
> >> now.
> >>
> >
> > I have reverted changes to three include files who's output appears in
> > the regression tests. I asssume this is new 9.0 behavior because I
> > didn't have this issue before. I also updated the pgindent script to
> > prevent these from being changed in the future.
> >
> >
>
> Should not the instructions include doing a full set of regression tests
> to ensure that nothing breaks? The new installcheck-world target should
> help there.

Wow, I didn't know that was available. I have updated the pgindent
README.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-02-26 18:11:44 Re: Avoiding bad prepared-statement plans.
Previous Message Greg Stark 2010-02-26 17:46:15 Re: Hot Standby query cancellation and Streaming Replication integration