| From: | "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Galy Lee <lee(dot)galy(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit |
| Date: | 2007-06-07 17:09:44 |
| Message-ID: | 46683BD8.9080707@zeut.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers pgsql-patches |
Alvaro Herrera wrote:
> Tom Lane wrote:
>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>> But this is misleading (started postmaster with good value, then edited
>>> postgresql.conf and entered "-2"):
>>> 17903 LOG: received SIGHUP, reloading configuration files
>>> 17903 LOG: -2 is outside the valid range for parameter "autovacuum_vacuum_cost_limit" (-1 .. 1000)
>>> Note how it still says the range is -1 .. 1000.
>> Can we redefine things to make zero be the "disabled" value, thus
>> keeping the range of valid values contiguous?
>
> That would be another solution ... though it would be different from the
> valid value for autovacuum_vacuum_cost_delay (on which 0 is a valid
> value). Also it would be a different value from previous versions.
>
> I don't think either of these is a showstopper, so let's go for that if
> nobody objects.
Can you make 0 and -1 both valid disabled values? That way it will be
compatible with previous releases.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-06-07 19:02:01 | Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit |
| Previous Message | Alvaro Herrera | 2007-06-07 16:54:03 | Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-06-07 17:23:41 | Re: Controlling Load Distributed Checkpoints |
| Previous Message | Alvaro Herrera | 2007-06-07 16:54:03 | Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-06-07 17:23:41 | Re: Controlling Load Distributed Checkpoints |
| Previous Message | Alvaro Herrera | 2007-06-07 16:54:03 | Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit |