Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Galy Lee <lee(dot)galy(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit
Date: 2007-06-07 19:02:01
Message-ID: 20070607190201.GE21004@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers pgsql-patches

Matthew T. O'Connor wrote:
> Alvaro Herrera wrote:
> >Tom Lane wrote:
> >>Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> >>>But this is misleading (started postmaster with good value, then edited
> >>>postgresql.conf and entered "-2"):
> >>>17903 LOG: received SIGHUP, reloading configuration files
> >>>17903 LOG: -2 is outside the valid range for parameter
> >>>"autovacuum_vacuum_cost_limit" (-1 .. 1000)
> >>>Note how it still says the range is -1 .. 1000.
> >>Can we redefine things to make zero be the "disabled" value, thus
> >>keeping the range of valid values contiguous?
> >
> >That would be another solution ... though it would be different from the
> >valid value for autovacuum_vacuum_cost_delay (on which 0 is a valid
> >value). Also it would be a different value from previous versions.
> >
> >I don't think either of these is a showstopper, so let's go for that if
> >nobody objects.
>
> Can you make 0 and -1 both valid disabled values? That way it will be
> compatible with previous releases.

Heh, sure, we can do that too and it doesn't seem like anybody would
object. I will patch the documentation so that that the "disabled"
value is zero, and still allow -1. That way it doesn't seem like there
should be any objection.

--
Alvaro Herrera http://www.flickr.com/photos/alvherre/
"Escucha y olvidarás; ve y recordarás; haz y entenderás" (Confucio)

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Felipe Nogueira 2007-06-08 13:36:18 BUG #3376: Erro : COMMIT
Previous Message Matthew T. O'Connor 2007-06-07 17:09:44 Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Hammond 2007-06-07 19:13:09 Re: Autovacuum launcher doesn't notice death of postmaster immediately
Previous Message Alvaro Herrera 2007-06-07 18:59:53 Re: Vacuuming anything zeroes shared table stats

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Hammond 2007-06-07 19:13:09 Re: Autovacuum launcher doesn't notice death of postmaster immediately
Previous Message Greg Smith 2007-06-07 18:58:50 Re: Controlling Load Distributed Checkpoints