Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Galy Lee <lee(dot)galy(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit
Date: 2007-06-07 16:54:03
Message-ID: 20070607165403.GS3664@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers pgsql-patches

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > But this is misleading (started postmaster with good value, then edited
> > postgresql.conf and entered "-2"):
>
> > 17903 LOG: received SIGHUP, reloading configuration files
> > 17903 LOG: -2 is outside the valid range for parameter "autovacuum_vacuum_cost_limit" (-1 .. 1000)
>
> > Note how it still says the range is -1 .. 1000.
>
> Can we redefine things to make zero be the "disabled" value, thus
> keeping the range of valid values contiguous?

That would be another solution ... though it would be different from the
valid value for autovacuum_vacuum_cost_delay (on which 0 is a valid
value). Also it would be a different value from previous versions.

I don't think either of these is a showstopper, so let's go for that if
nobody objects.

--
Alvaro Herrera Developer, http://www.PostgreSQL.org/
<inflex> really, I see PHP as like a strange amalgamation of C, Perl, Shell
<crab> inflex: you know that "amalgam" means "mixture with mercury",
more or less, right?
<crab> i.e., "deadly poison"

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Matthew T. O'Connor 2007-06-07 17:09:44 Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit
Previous Message Tom Lane 2007-06-07 16:18:44 Re: [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthew T. O'Connor 2007-06-07 17:09:44 Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit
Previous Message Tom Lane 2007-06-07 16:18:44 Re: [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit

Browse pgsql-patches by date

  From Date Subject
Next Message Matthew T. O'Connor 2007-06-07 17:09:44 Re: [PATCHES] [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit
Previous Message Tom Lane 2007-06-07 16:18:44 Re: [BUGS] BUG #3326: Invalid lower bound of autovacuum_cost_limit