| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-19 15:24:02 |
| Message-ID: | 454653fd-d2ab-45f1-9568-9342c1ed9d77@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18.12.23 14:52, Peter Eisentraut wrote:
>> 2) I had seen that if sed/gzip is not available meson build will fail:
>> 2.a)
>> Program gsed sed found: NO
>> meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable
>
> Yes, this would need to be improved. Currently, sed is only required if
> either selinux or dtrace is enabled, which isn't supported on Windows.
> But we should adjust the build scripts to not fail the top-level setup
> run unless those options are enabled.
>
>> 2.b)
>> Program gzip found: NO
>> meson.build:337:7: ERROR: Program 'gzip' not found or not executable
>
> gzip is only required for certain test suites, so again we should adjust
> the build scripts to not fail the build but instead skip the tests as
> appropriate.
Here are patches for these two issues. More testing would be appreciated.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-meson-Require-sed-only-when-needed.patch | text/plain | 1.2 KB |
| 0002-meson-Make-gzip-and-tar-optional.patch | text/plain | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2023-12-19 15:33:54 | Re: Add --check option to pgindent |
| Previous Message | Tom Lane | 2023-12-19 15:13:39 | Re: Allow custom parameters with more than one dot in config files. |