| From: | "Tristan Partin" <tristan(at)neon(dot)tech> |
|---|---|
| To: | "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "vignesh C" <vignesh21(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz> |
| Cc: | "Shubham Khanna" <khannashubham1197(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, "Postgres hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-19 16:10:45 |
| Message-ID: | CXSFWV0W5S6O.1E1PO04V0FO1D@neon.tech |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue Dec 19, 2023 at 9:24 AM CST, Peter Eisentraut wrote:
> On 18.12.23 14:52, Peter Eisentraut wrote:
> >> 2) I had seen that if sed/gzip is not available meson build will fail:
> >> 2.a)
> >> Program gsed sed found: NO
> >> meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable
> >
> > Yes, this would need to be improved. Currently, sed is only required if
> > either selinux or dtrace is enabled, which isn't supported on Windows.
> > But we should adjust the build scripts to not fail the top-level setup
> > run unless those options are enabled.
> >
> >> 2.b)
> >> Program gzip found: NO
> >> meson.build:337:7: ERROR: Program 'gzip' not found or not executable
> >
> > gzip is only required for certain test suites, so again we should adjust
> > the build scripts to not fail the build but instead skip the tests as
> > appropriate.
>
> Here are patches for these two issues. More testing would be appreciated.
Meson looks good to me!
--
Tristan Partin
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-12-19 16:11:35 | Re: backtrace_on_internal_error |
| Previous Message | Nathan Bossart | 2023-12-19 16:09:39 | Re: introduce dynamic shared memory registry |