| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-20 01:14:55 |
| Message-ID: | ZYJADzR_80Dy7I9-@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 19, 2023 at 04:24:02PM +0100, Peter Eisentraut wrote:
> Here are patches for these two issues. More testing would be appreciated.
>
> --- a/contrib/basebackup_to_shell/meson.build
> +++ b/contrib/basebackup_to_shell/meson.build
> @@ -24,7 +24,7 @@ tests += {
> 'tests': [
> 't/001_basic.pl',
> ],
> - 'env': {'GZIP_PROGRAM': gzip.path(),
> - 'TAR': tar.path()},
> + 'env': {'GZIP_PROGRAM': gzip.found() ? gzip.path() : '',
> + 'TAR': tar.found() ? tar.path() : '' },
> },
Hmm. Interesting. So this basically comes down to the fact that GZIP
and TAR are required in ./configure because distcheck has a hard
dependency on both, but we don't support this target in meson. Is
that right?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-12-20 01:19:02 | Re: Improve eviction algorithm in ReorderBuffer |
| Previous Message | Michael Paquier | 2023-12-20 01:01:16 | Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common. |