Re: pgsql: Fix compiler warnings on 64-bit boxes:

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: Teodor Sigaev <teodor(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix compiler warnings on 64-bit boxes:
Date: 2006-09-06 08:05:41
Message-ID: 44FE8155.9080401@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

> It might seem a minor quibble, but it seems like a more reliable approach
> might be to cast to a 64 bit type and user a 64 bit int formatter.
%ld ? %lld? depending on architecture?

>
> It seems unlikely that state->ptr - state->begin would yield a number that
> large but I don't know that that would be true of every platform or user.

I don't believe that it can be more that 1Gb - it's a limit for any varlena type.

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Gavin Sherry 2006-09-06 08:13:37 Re: pgsql: Fix compiler warnings on 64-bit boxes:
Previous Message Gavin Sherry 2006-09-06 07:37:46 Re: pgsql: Fix compiler warnings on 64-bit boxes:

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paesold 2006-09-06 08:11:13 Re: Win32 hard crash problem
Previous Message Gavin Sherry 2006-09-06 07:37:46 Re: pgsql: Fix compiler warnings on 64-bit boxes: