Re: pgsql: Fix compiler warnings on 64-bit boxes:

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix compiler warnings on 64-bit boxes:
Date: 2006-09-06 08:13:37
Message-ID: Pine.LNX.4.58.0609061812130.6703@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, 6 Sep 2006, Teodor Sigaev wrote:

> > It might seem a minor quibble, but it seems like a more reliable approach
> > might be to cast to a 64 bit type and user a 64 bit int formatter.
> %ld ? %lld? depending on architecture?
>
> >
> > It seems unlikely that state->ptr - state->begin would yield a number that
> > large but I don't know that that would be true of every platform or user.
>
> I don't believe that it can be more that 1Gb - it's a limit for any varlena type.
>

True. int32 should be fine.

Thanks,

gavin

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Knt 2006-09-06 08:48:38 plscheme - plscheme: Added basic SPI_execute functionality and corrected
Previous Message Teodor Sigaev 2006-09-06 08:05:41 Re: pgsql: Fix compiler warnings on 64-bit boxes:

Browse pgsql-hackers by date

  From Date Subject
Next Message Zeugswetter Andreas DCP SD 2006-09-06 08:21:41 Re: @ versus ~, redux
Previous Message Michael Paesold 2006-09-06 08:11:13 Re: Win32 hard crash problem