From: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
---|---|
To: | Teodor Sigaev <teodor(at)postgresql(dot)org> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Fix compiler warnings on 64-bit boxes: |
Date: | 2006-09-06 07:37:46 |
Message-ID: | Pine.LNX.4.58.0609061730360.6458@linuxworld.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, 6 Sep 2006, Teodor Sigaev wrote:
> Log Message:
> -----------
> Fix compiler warnings on 64-bit boxes: difference between
> pointers are int64, but warnings are emitted for position info in
> error messages in parser, so, just cast it to int32
>
> Modified Files:
> --------------
> pgsql/contrib/hstore:
> hstore_io.c (r1.1 -> r1.2)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/hstore/hstore_io.c.diff?r1=1.1&r2=1.2)
It might seem a minor quibble, but it seems like a more reliable approach
might be to cast to a 64 bit type and user a 64 bit int formatter.
It seems unlikely that state->ptr - state->begin would yield a number that
large but I don't know that that would be true of every platform or user.
Thanks,
Gavin
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2006-09-06 08:05:41 | Re: pgsql: Fix compiler warnings on 64-bit boxes: |
Previous Message | Teodor Sigaev | 2006-09-06 07:22:14 | pgsql: Fix compiler warnings on 64-bit boxes: difference between |
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2006-09-06 08:05:41 | Re: pgsql: Fix compiler warnings on 64-bit boxes: |
Previous Message | Magnus Hagander | 2006-09-06 07:27:06 | Re: Win32 hard crash problem |