Re: Add trailing commas to enum definitions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Junwang Zhao <zhjwpku(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add trailing commas to enum definitions
Date: 2023-10-23 21:04:08
Message-ID: 429018.1698095048@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> From a long-term perspective, I
> think standardizing on the trailing comma style will actually improve
> git-blame because patches won't need to add a comma to the previous line
> when adding a value.

Yeah, that's a good point. I had been leaning towards "this is
unnecessary churn", but with that idea I'm now +1.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2023-10-23 21:08:12 Re: PostgreSQL domains and NOT NULL constraint
Previous Message Vik Fearing 2023-10-23 21:01:17 Re: PostgreSQL domains and NOT NULL constraint