Re: Add trailing commas to enum definitions

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Junwang Zhao <zhjwpku(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add trailing commas to enum definitions
Date: 2023-10-24 12:58:38
Message-ID: 2bce3a0b-250c-b2ed-2e91-e126072fecaf@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-10-23 Mo 17:04, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> From a long-term perspective, I
>> think standardizing on the trailing comma style will actually improve
>> git-blame because patches won't need to add a comma to the previous line
>> when adding a value.
> Yeah, that's a good point. I had been leaning towards "this is
> unnecessary churn", but with that idea I'm now +1.
>
>

+1. It's a fairly common practice in Perl code, too, and I often do it
for exactly this reason.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-10-24 13:11:47 Re: More new SQL/JSON item methods
Previous Message Robert Haas 2023-10-24 12:58:04 Re: Various bugs if segment containing redo pointer does not exist