From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: More new SQL/JSON item methods |
Date: | 2023-10-24 13:11:47 |
Message-ID: | bc03e76e-15d6-744e-db53-2e4417b5fe05@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2023-10-19 Th 02:06, Jeevan Chalke wrote:
> Thanks, Peter for the comments.
>
> On Fri, Oct 6, 2023 at 5:13 PM Peter Eisentraut <peter(at)eisentraut(dot)org>
> wrote:
>
> On 29.08.23 09:05, Jeevan Chalke wrote:
> > v1-0001-Implement-jsonpath-.bigint-.integer-and-.number-m.patch
> >
> > This commit implements jsonpath .bigint(), .integer(), and .number()
> > methods. The JSON string or a numeric value is converted to the
> > bigint, int4, and numeric type representation.
>
> A comment that applies to all of these: These add various keywords,
> switch cases, documentation entries in some order. Are we happy with
> that? Should we try to reorder all of that for better
> maintainability
> or readability?
>
>
> Yeah, that's the better suggestion. While implementing these methods,
> I was confused about where to put them exactly and tried keeping them
> in some logical place.
> I think once these methods get in, we can have a follow-up patch
> reorganizing all of these.
I think it would be better to organize things how we want them before
adding in more stuff.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2023-10-24 13:40:01 | Re: run pgindent on a regular basis / scripted manner |
Previous Message | Andrew Dunstan | 2023-10-24 12:58:38 | Re: Add trailing commas to enum definitions |