| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add trailing commas to enum definitions |
| Date: | 2023-10-23 23:58:23 |
| Message-ID: | 6bd2a913-584e-445b-8c77-c4aba4bb3c29@pgmasters.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/23/23 17:04, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> From a long-term perspective, I
>> think standardizing on the trailing comma style will actually improve
>> git-blame because patches won't need to add a comma to the previous line
>> when adding a value.
>
> Yeah, that's a good point. I had been leaning towards "this is
> unnecessary churn", but with that idea I'm now +1.
+1 from me.
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii.Yuki@df.MitsubishiElectric.co.jp | 2023-10-24 00:12:41 | RE: Partial aggregates pushdown |
| Previous Message | David Steele | 2023-10-23 23:56:51 | Re: trying again to get incremental backup |