From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Martín Marqués <martin(at)2ndquadrant(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: pg_dump doesn't dump new objects created in schemas from extensions |
Date: | 2016-06-22 17:21:42 |
Message-ID: | 4193.1466616102@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
=?UTF-8?Q?Mart=c3=adn_Marqu=c3=a9s?= <martin(at)2ndquadrant(dot)com> writes:
> On HEAD I actually see that we *are* setting dump_contains as well:
> if (fout->remoteVersion < 90600)
> dobj->dump = DUMP_COMPONENT_NONE;
> else
> dobj->dump = ext->dobj.dump_contains & (DUMP_COMPONENT_ACL |
> DUMP_COMPONENT_SECLABEL | DUMP_COMPONENT_POLICY);
Uh, what?
(BTW, Stephen, what's the point of the version check here? The 'else'
code seems like it would work just fine in all branches.)
>> So maybe just moving the checkExtensionMembership call to after the other
>> stuff would be enough in HEAD?
> Looking into older versions as well I can't see how placing
> checkExtensionMembership at the end of selectDumpableNamespace would
> help. (like-wise for other selectDumpable's)
The fix in HEAD will necessarily look quite a bit different from
the back branches, I fear. But the idea I had in mind there was that
we'd calculate a namespace's dump and dump_contains flags as if it
were not an extension member, and then allow checkExtensionMembership
to overwrite the dump flags if it is a member. Since
checkExtensionMembership doesn't touch the dump_contains flags, that
would leave all the flags in the desired state.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Martín Marqués | 2016-06-22 18:37:58 | Re: pg_dump doesn't dump new objects created in schemas from extensions |
Previous Message | Martín Marqués | 2016-06-22 17:05:32 | Re: pg_dump doesn't dump new objects created in schemas from extensions |