Re: pg_dump doesn't dump new objects created in schemas from extensions

From: Martín Marqués <martin(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: pg_dump doesn't dump new objects created in schemas from extensions
Date: 2016-08-09 19:27:28
Message-ID: 36a1111f-58b9-bec8-fb18-c862ca6fe285@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi, couldn't find a committed patch to fix this. Did I miss it in the
pile of logs?

El 22/06/16 a las 14:21, Tom Lane escribió:
>
>>> So maybe just moving the checkExtensionMembership call to after the other
>>> stuff would be enough in HEAD?
>
>> Looking into older versions as well I can't see how placing
>> checkExtensionMembership at the end of selectDumpableNamespace would
>> help. (like-wise for other selectDumpable's)
>
> The fix in HEAD will necessarily look quite a bit different from
> the back branches, I fear. But the idea I had in mind there was that
> we'd calculate a namespace's dump and dump_contains flags as if it
> were not an extension member, and then allow checkExtensionMembership
> to overwrite the dump flags if it is a member. Since
> checkExtensionMembership doesn't touch the dump_contains flags, that
> would leave all the flags in the desired state.

Was drifted away but can make some time now to add a proper test for
this and a fix around Tom's thoughts.

Regards,

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message lr 2016-08-09 20:34:35 BUG #14286: PostgreSQL build tests segfaulting
Previous Message Tom Lane 2016-08-09 17:41:08 Re: 9.5 Create Function Set From Current taken at creation time?