Re: pg_dump doesn't dump new objects created in schemas from extensions

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Martín Marqués <martin(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: pg_dump doesn't dump new objects created in schemas from extensions
Date: 2016-08-09 23:25:09
Message-ID: CAB7nPqQ9VG6py8P_KVEj-r-4QwTWZ3nxfPxBJ4vP8KJpnaGBcA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Aug 10, 2016 at 4:27 AM, Martín Marqués <martin(at)2ndquadrant(dot)com> wrote:
> El 22/06/16 a las 14:21, Tom Lane escribió:
>>>> So maybe just moving the checkExtensionMembership call to after the other
>>>> stuff would be enough in HEAD?
>>
>>> Looking into older versions as well I can't see how placing
>>> checkExtensionMembership at the end of selectDumpableNamespace would
>>> help. (like-wise for other selectDumpable's)
>>
>> The fix in HEAD will necessarily look quite a bit different from
>> the back branches, I fear. But the idea I had in mind there was that
>> we'd calculate a namespace's dump and dump_contains flags as if it
>> were not an extension member, and then allow checkExtensionMembership
>> to overwrite the dump flags if it is a member. Since
>> checkExtensionMembership doesn't touch the dump_contains flags, that
>> would leave all the flags in the desired state.

> Hi, couldn't find a committed patch to fix this. Did I miss it in the
> pile of logs?

No, it seems that everybody was waiting for you here, and least that's my case.

> Was drifted away but can make some time now to add a proper test for
> this and a fix around Tom's thoughts.

Yes, that would be nice. And some necessary tests can be added at
least on HEAD, see for example f9e439b1.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Martín Marqués 2016-08-10 14:01:53 Re: pg_dump doesn't dump new objects created in schemas from extensions
Previous Message Michael Paquier 2016-08-09 23:03:18 Re: BUG #14228: replication slot catalog_xmin not cleared on slot reuse