| From: | Martín Marqués <martin(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: pg_dump doesn't dump new objects created in schemas from extensions |
| Date: | 2016-06-22 18:37:58 |
| Message-ID: | 621b0bd6-8dd9-1aa0-6ac6-c6b73d05ade9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
El 22/06/16 a las 14:21, Tom Lane escribió:
>
>> Looking into older versions as well I can't see how placing
>> checkExtensionMembership at the end of selectDumpableNamespace would
>> help. (like-wise for other selectDumpable's)
>
> The fix in HEAD will necessarily look quite a bit different from
> the back branches, I fear. But the idea I had in mind there was that
> we'd calculate a namespace's dump and dump_contains flags as if it
> were not an extension member, and then allow checkExtensionMembership
> to overwrite the dump flags if it is a member. Since
> checkExtensionMembership doesn't touch the dump_contains flags, that
> would leave all the flags in the desired state.
Oh, that's very reasonable.
I wonder how that would look on version < 9.6. Will have a look at it on
HEAD and 9.5 (I guess changes back to 9.2 or 9.1 should be fairly
similar, but I'll verify)
--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Sobolev | 2016-06-22 18:49:33 | Re: BUG #14206: Switch to using POSIX semaphores on FreeBSD |
| Previous Message | Tom Lane | 2016-06-22 17:21:42 | Re: pg_dump doesn't dump new objects created in schemas from extensions |