| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: rmtree cleanup |
| Date: | 2004-10-29 00:33:09 |
| Message-ID: | 41818FC5.8080101@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>The attached patch cleans up src/port/dirmod.c::rmtree() a bit. It moves
>>the filename finding portion into its own function, and in that function
>>only scans the directory once instead of twice.
>>
>>
>
>Applied, along with some further hacking to reduce the #ifdef clutter
>by providing palloc substitute routines.
>
Nice. It's actually readable now :-)
>I checked it still works on
>Unix, would you check I didn't break the Windows cases?
>
>
>
>
Yes, it works. Thanks.
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2004-10-29 01:00:28 | Re: transformExpr() refactor |
| Previous Message | Tom Lane | 2004-10-28 22:57:08 | Re: pg_autovacuum vacuum cost variables patch v2 |