Re: rmtree cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: rmtree cleanup
Date: 2004-10-28 22:10:44
Message-ID: 7462.1099001444@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The attached patch cleans up src/port/dirmod.c::rmtree() a bit. It moves
> the filename finding portion into its own function, and in that function
> only scans the directory once instead of twice.

Applied, along with some further hacking to reduce the #ifdef clutter
by providing palloc substitute routines. I checked it still works on
Unix, would you check I didn't break the Windows cases?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-10-28 22:31:32 Re: dblink crash fix
Previous Message Tom Lane 2004-10-28 18:55:45 Re: sign parsing (was: Re: [HACKERS] to_char/to_number loses sign)