| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: transformExpr() refactor |
| Date: | 2004-10-29 01:00:28 |
| Message-ID: | 1099011628.21058.15.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Fri, 2004-10-29 at 00:17, Tom Lane wrote:
> I don't actually find this to be an improvement. What's the point?
> Since all the switch arms are independent, you haven't really done
> anything at all to improve the comprehensibility of the code...
I think the code is more readable this way. The very fact that the
switch branches are completely independent is good enough reason to make
them distinct functions, IMHO. Breaking 900 lines of code into smaller
chunks of code, each of which does a single conceptual task, just makes
the whole enterprise easier to understand. As for sharing code between
the functions, I agree that isn't done today -- but it will be easier to
do in the future with this refactoring.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Treat | 2004-10-29 01:09:51 | FAQ update |
| Previous Message | Andrew Dunstan | 2004-10-29 00:33:09 | Re: rmtree cleanup |