Re: transformExpr() refactor

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: transformExpr() refactor
Date: 2004-10-28 14:17:51
Message-ID: 1673.1098973071@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> This patch refactors transformExpr(): rather than being a monsterous 900
> line function, it breaks it up into numerous sub-functions that are
> invoked by transformExpr() for individual expression types, in the style
> of transformStmt().

I don't actually find this to be an improvement. What's the point?
Since all the switch arms are independent, you haven't really done
anything at all to improve the comprehensibility of the code...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-10-28 14:33:34 rmtree cleanup
Previous Message Peter Eisentraut 2004-10-28 09:37:08 Re: Updated Turkish translation: postgres