| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: stand-alone composite types patch (was [HACKERS] Proposal: |
| Date: | 2002-08-15 05:19:19 |
| Message-ID: | 3D5B39D7.6010709@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> There's no longer a separate call to heap_storage_create in that routine
> --- the right place to make the test is now in the storage_create
> boolean parameter being passed to heap_create. A simple change, but
> it passeth patch's understanding ...
Thanks.
Attached is a patch against cvs tip as of 8:30 PM PST or so. Turned out
that even after fixing the failed hunks, there was a new spot in
bufmgr.c which needed to be fixed (related to temp relations;
RelationUpdateNumberOfBlocks). But thankfully the regression test code
caught it :-)
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| comp-type.2002.08.14.2.patch | text/plain | 41.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2002-08-15 05:21:21 | Re: contrib Makefiles |
| Previous Message | Tom Lane | 2002-08-15 05:09:26 | Re: contrib Makefiles |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ulrich Neumann | 2002-08-15 10:46:28 | Antw: Re: File for /src/backend/port/netware |
| Previous Message | Rod Taylor | 2002-08-15 04:09:45 | Docbook 4.2 support |