Re: stand-alone composite types patch (was [HACKERS] Proposal:

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Joe Conway <mail(at)joeconway(dot)com>, Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: stand-alone composite types patch (was [HACKERS] Proposal:
Date: 2002-08-15 03:30:35
Message-ID: 19194.1029382235@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> [ this doesn't apply: ]

> /*
> * We create the disk file for this relation here
> */
> ! if (relkind != RELKIND_VIEW)
> heap_storage_create(new_rel_desc);

> /*
> --- 764,770 ----
> /*
> * We create the disk file for this relation here
> */
> ! if (relkind != RELKIND_VIEW && relkind != RELKIND_COMPOSITE_TYPE)
> heap_storage_create(new_rel_desc);

> /*

There's no longer a separate call to heap_storage_create in that routine
--- the right place to make the test is now in the storage_create
boolean parameter being passed to heap_create. A simple change, but
it passeth patch's understanding ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-08-15 03:31:56 Re: python patch
Previous Message Joe Conway 2002-08-15 03:19:45 Re: stand-alone composite types patch (was [HACKERS] Proposal:

Browse pgsql-patches by date

  From Date Subject
Next Message Denis A Ustimenko 2002-08-15 03:43:22 Re: connect_timeout parameter in libpq
Previous Message Joe Conway 2002-08-15 03:19:45 Re: stand-alone composite types patch (was [HACKERS] Proposal: