| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: anonymous composite types for Table Functions (aka |
| Date: | 2002-08-05 04:19:22 |
| Message-ID: | 3D4DFCCA.6040907@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Hm. I'd sort of expect the "z" to become both the table and column
> alias in this case. What do you think?
I guess that would make sense. I'll make a separate patch just for that
change if that's OK.
> Other examples look good. Code style comment:
>
>
>>+ if (functyptype != 'p' || (functyptype == 'p' && funcrettype != RECORDOID))
>
>
> This test seems redundant, why not
>
> if (functyptype != 'p' || funcrettype != RECORDOID)
>
You're correct, of course. But I started out with a much more convoluted
test than that, so at least this was an improvement ;-)
Joe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Copeland | 2002-08-05 04:21:38 | Re: PITR, checkpoint, and local relations |
| Previous Message | Christopher Kings-Lynne | 2002-08-05 04:09:49 | Re: anonymous composite types for Table Functions (aka |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2002-08-05 05:57:26 | Re: anonymous composite types for Table Functions (aka |
| Previous Message | Christopher Kings-Lynne | 2002-08-05 04:09:49 | Re: anonymous composite types for Table Functions (aka |