Re: anonymous composite types for Table Functions (aka SRFs)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: anonymous composite types for Table Functions (aka SRFs)
Date: 2002-08-05 04:08:33
Message-ID: 14391.1028520513@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> Tom Lane wrote:
>> regression=# select * from foo() as z;
>> foo
>> ------
>> 8800
>> ...
>>
>> (hm, what happened to the alias?)

> Actually nothing wrong with this one. The z is the relation alias, not
> the column alias. The column alias defaults to the function name for
> SRFs returning scalar.

Hm. I'd sort of expect the "z" to become both the table and column
alias in this case. What do you think?

Other examples look good. Code style comment:

> + if (functyptype != 'p' || (functyptype == 'p' && funcrettype != RECORDOID))

This test seems redundant, why not

if (functyptype != 'p' || funcrettype != RECORDOID)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2002-08-05 04:09:49 Re: anonymous composite types for Table Functions (aka
Previous Message Joe Conway 2002-08-05 04:08:25 Re: FUNC_MAX_ARGS benchmarks

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2002-08-05 04:09:49 Re: anonymous composite types for Table Functions (aka
Previous Message Joe Conway 2002-08-05 04:00:31 Re: anonymous composite types for Table Functions (aka