Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Date: 2023-02-12 21:20:46
Message-ID: 3A6C72BD-50D3-4B8B-B614-CDE83E7E1FBC@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On February 12, 2023 1:11:08 PM PST, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Andres Freund <andres(at)anarazel(dot)de> writes:
>> Cfbot didn't catch this, because it only triggered a warning, not a failure. We probably should add -Werror?
>
>Yeah -- nobody is going to go digging through cfbot logs for warnings,
>especially when they know that the Compiler Warnings task is supposed
>to complain about those.
>
>I don't think -Werror helps any though; it's a matter of whether the
>cfbot is paying attention to headerscheck's exit status ...

Thomas fixed that part a while ago, but it'll just return 0 if it just is a warning...

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-02-12 21:25:28 Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Previous Message Tom Lane 2023-02-12 21:11:08 Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.