Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Date: 2023-02-12 21:25:28
Message-ID: 962481.1676237128@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On February 12, 2023 1:11:08 PM PST, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't think -Werror helps any though; it's a matter of whether the
>> cfbot is paying attention to headerscheck's exit status ...

> Thomas fixed that part a while ago, but it'll just return 0 if it just is a warning...

Hmm, but why'd the buildfarm complain then? ... oh, because it checks
for nonempty output as well as nonzero exit status.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-02-12 22:21:41 Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Previous Message Andres Freund 2023-02-12 21:20:46 Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.