Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Date: 2023-02-12 21:11:08
Message-ID: 960944.1676236268@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Cfbot didn't catch this, because it only triggered a warning, not a failure. We probably should add -Werror?

Yeah -- nobody is going to go digging through cfbot logs for warnings,
especially when they know that the Compiler Warnings task is supposed
to complain about those.

I don't think -Werror helps any though; it's a matter of whether the
cfbot is paying attention to headerscheck's exit status ...

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-02-12 21:20:46 Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Previous Message Andres Freund 2023-02-12 20:12:55 Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.