Re: [PATCH] clarify palloc comment on quote_literal_cstr

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] clarify palloc comment on quote_literal_cstr
Date: 2025-04-08 05:26:59
Message-ID: 3894912.1744090019@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Hmm. I don't think that grouping all these details in the same
> comment block is an improvement in this case compared to the first
> version, where it is clear which part of the calculation applies to
> what. In short, I'm OK with how things are on HEAD.

+1. When I saw the patch I was mainly afraid that pgindent would
make a hash of it. But it didn't, so I'm cool with it as-is.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nico Williams 2025-04-08 05:35:39 Re: pg16 && GSSAPI && Heimdal/Macos
Previous Message Michael Paquier 2025-04-08 05:19:07 Re: [PATCH] clarify palloc comment on quote_literal_cstr