| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] clarify palloc comment on quote_literal_cstr |
| Date: | 2025-04-08 05:19:07 |
| Message-ID: | Z_SxywpaJsu1mRVG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 08, 2025 at 08:47:53AM +0530, Ashutosh Bapat wrote:
> Thanks for addressing the comment.
>
> In PG code, we start a multiline comment with just /* on the first
> line and end with just */ on the last line. All the lines in-between
> start with * . Please check other comments in the file.
>
> I would write a., b. c. d. on separate lines.
Hmm. I don't think that grouping all these details in the same
comment block is an improvement in this case compared to the first
version, where it is clear which part of the calculation applies to
what. In short, I'm OK with how things are on HEAD.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-04-08 05:26:59 | Re: [PATCH] clarify palloc comment on quote_literal_cstr |
| Previous Message | Michael Paquier | 2025-04-08 05:13:20 | Re: Fix 035_standby_logical_decoding.pl race conditions |