| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: improve ssl error code, 2147483650 |
| Date: | 2024-07-24 13:32:38 |
| Message-ID: | 337a869d-9d99-40a1-aef1-c70806498768@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25.06.24 16:21, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> On 21.06.24 16:53, Tom Lane wrote:
>>> Most of libpq gets at strerror_r via SOCK_STRERROR for Windows
>>> portability. Is that relevant here?
>
>> Looking inside the OpenSSL code, it makes no efforts to translate
>> between winsock error codes and standard error codes, so I don't think
>> our workaround/replacement code needs to do that either.
>
> Fair enough.
>
>> Btw., our source code comments say something like
>> "ERR_reason_error_string randomly refuses to map system errno values."
>> The reason it doesn't is exactly that it can't do it while maintaining
>> thread-safety.
>
> Ah. Do you want to improve that comment while you're at it?
Here is a patch that fixes the strerror() call and updates the comments
a bit.
This ought to be backpatched like the original fix; ideally for the next
minor releases in about two weeks.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-libpq-Use-strerror_r-instead-of-strerror.patch | text/plain | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2024-07-24 13:45:19 | Re: Send duration output to separate log files |
| Previous Message | Jeremy Schneider | 2024-07-24 13:29:31 | Re: [18] Policy on IMMUTABLE functions and Unicode updates |