From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: improve ssl error code, 2147483650 |
Date: | 2024-07-25 09:36:57 |
Message-ID: | 3F545992-E1C9-4451-9F30-7D5950096B61@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 24 Jul 2024, at 15:32, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 25.06.24 16:21, Tom Lane wrote:
>> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>>> On 21.06.24 16:53, Tom Lane wrote:
>>>> Most of libpq gets at strerror_r via SOCK_STRERROR for Windows
>>>> portability. Is that relevant here?
>>> Looking inside the OpenSSL code, it makes no efforts to translate
>>> between winsock error codes and standard error codes, so I don't think
>>> our workaround/replacement code needs to do that either.
>> Fair enough.
>>> Btw., our source code comments say something like
>>> "ERR_reason_error_string randomly refuses to map system errno values."
>>> The reason it doesn't is exactly that it can't do it while maintaining
>>> thread-safety.
>> Ah. Do you want to improve that comment while you're at it?
>
> Here is a patch that fixes the strerror() call and updates the comments a bit.
LGTM.
> This ought to be backpatched like the original fix; ideally for the next minor releases in about two weeks.
Agreed.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2024-07-25 09:42:55 | Re: optimizing pg_upgrade's once-in-each-database steps |
Previous Message | Michael Paquier | 2024-07-25 08:55:19 | Re: REINDEX not updating partition progress |