| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: improve ssl error code, 2147483650 |
| Date: | 2024-06-25 14:21:58 |
| Message-ID: | 1318844.1719325318@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 21.06.24 16:53, Tom Lane wrote:
>> Most of libpq gets at strerror_r via SOCK_STRERROR for Windows
>> portability. Is that relevant here?
> Looking inside the OpenSSL code, it makes no efforts to translate
> between winsock error codes and standard error codes, so I don't think
> our workaround/replacement code needs to do that either.
Fair enough.
> Btw., our source code comments say something like
> "ERR_reason_error_string randomly refuses to map system errno values."
> The reason it doesn't is exactly that it can't do it while maintaining
> thread-safety.
Ah. Do you want to improve that comment while you're at it?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-06-25 14:23:53 | Re: add a new explain option including_query for include query string inside the json plan output |
| Previous Message | Dave Cramer | 2024-06-25 14:20:30 | Re: Direct SSL connection and ALPN loose ends |