Re: pgsql: Add a regression test for allow_system_table_mods

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Date: 2019-11-29 16:04:45
Message-ID: 315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-11-29 16:27, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> Add a regression test for allow_system_table_mods
>
> Oooh ... some of the buildfarm members are pointing out that this
> didn't follow a project convention:

Um, yes, that's why it's in unsafe_tests. Is there a way around this?

>
> @@ -153,6 +153,7 @@
> ROLLBACK;
> -- reserved tablespace name
> CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
> +WARNING: tablespaces created by regression test cases should have names starting with "regress_"
> ERROR: directory "/no/such/location" does not exist
> -- triggers
> CREATE TRIGGER t1 BEFORE INSERT ON pg_description EXECUTE FUNCTION tf1();
>
> regards, tom lane
>

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-11-29 16:09:06 Re: pgsql: Add a regression test for allow_system_table_mods
Previous Message Tom Lane 2019-11-29 15:27:47 Re: pgsql: Add a regression test for allow_system_table_mods