Re: pgsql: Add a regression test for allow_system_table_mods

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Date: 2019-11-29 15:27:47
Message-ID: 13656.1575041267@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> Add a regression test for allow_system_table_mods

Oooh ... some of the buildfarm members are pointing out that this
didn't follow a project convention:

@@ -153,6 +153,7 @@
ROLLBACK;
-- reserved tablespace name
CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
+WARNING: tablespaces created by regression test cases should have names starting with "regress_"
ERROR: directory "/no/such/location" does not exist
-- triggers
CREATE TRIGGER t1 BEFORE INSERT ON pg_description EXECUTE FUNCTION tf1();

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-11-29 16:04:45 Re: pgsql: Add a regression test for allow_system_table_mods
Previous Message Amit Kapila 2019-11-29 13:42:31 Re: pgsql: Add tests for '-f' option in dropdb utility.