Re: pgsql: Change fastgetattr and heap_getattr to inline functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Change fastgetattr and heap_getattr to inline functions
Date: 2022-03-24 18:09:49
Message-ID: 3029088.1648145389@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Change fastgetattr and heap_getattr to inline functions

wrasse isn't happy with this:

ccache /opt/developerstudio12.6/bin/cc -m64 -Xa -v -O pg_resetwal.o -L../../../src/port -L../../../src/common -L/home/nm/sw/nopath/uuid-64/lib -L/home/nm/sw/nopath/openldap-64/lib -Wl,--as-needed -Wl,-R'/home/nm/farm/studio64v12_6/HEAD/inst/lib' -lpgcommon -lpgport -lxslt -lxml2 -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -ltermcap -lnsl -lsocket -lm -o pg_resetwal
Undefined first referenced
symbol in file
nocachegetattr pg_resetwal.o
ld: fatal: symbol referencing errors

I believe you need to wrap those new inline functions in
"#ifndef FRONTEND".

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-03-24 18:31:21 pgsql: Wrap inline function definitions in #ifndef FRONTEND
Previous Message Tomas Vondra 2022-03-24 17:49:45 pgsql: Add decoding of sequences to built-in replication