pgsql: Change fastgetattr and heap_getattr to inline functions

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Change fastgetattr and heap_getattr to inline functions
Date: 2022-03-24 17:03:15
Message-ID: E1nXQrj-001C9h-8Y@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Change fastgetattr and heap_getattr to inline functions

They were macros previously, but recent callsite additions made Coverity
complain about one of the assertions being always true. This change
could have been made a long time ago, but the Coverity complain broke
the inertia.

Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Japin Li <japinli(at)hotmail(dot)com>
Reviewed-by: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/202203241021.uts52sczx3al@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e27f4ee0a701854daf16ac1d044f20d28a17053e

Modified Files
--------------
src/backend/access/heap/heapam.c | 46 ------------
src/include/access/htup_details.h | 151 +++++++++++++++++---------------------
2 files changed, 69 insertions(+), 128 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-03-24 17:34:45 pgsql: Doc: add some documentation about serialization failure handling
Previous Message Tom Lane 2022-03-24 15:47:52 pgsql: Invent recursive_worktable_factor GUC to replace hard-wired cons