Re: pgsql: Change fastgetattr and heap_getattr to inline functions

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Change fastgetattr and heap_getattr to inline functions
Date: 2022-03-24 18:32:13
Message-ID: 202203241832.7ojy5mwcbmij@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2022-Mar-24, Tom Lane wrote:

> wrasse isn't happy with this:
>
> ccache /opt/developerstudio12.6/bin/cc -m64 -Xa -v -O pg_resetwal.o -L../../../src/port -L../../../src/common -L/home/nm/sw/nopath/uuid-64/lib -L/home/nm/sw/nopath/openldap-64/lib -Wl,--as-needed -Wl,-R'/home/nm/farm/studio64v12_6/HEAD/inst/lib' -lpgcommon -lpgport -lxslt -lxml2 -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -ltermcap -lnsl -lsocket -lm -o pg_resetwal
> Undefined first referenced
> symbol in file
> nocachegetattr pg_resetwal.o
> ld: fatal: symbol referencing errors
>
> I believe you need to wrap those new inline functions in
> "#ifndef FRONTEND".

Ah, hadn't seen that, thanks. Pushed that as fix.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-03-24 19:32:54 pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.
Previous Message Alvaro Herrera 2022-03-24 18:31:21 pgsql: Wrap inline function definitions in #ifndef FRONTEND