| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |
| Date: | 2023-04-26 12:31:38 |
| Message-ID: | 2EE2FBAC-A190-45A4-8381-F51CCB61A037@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 26 Apr 2023, at 13:26, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Wed, 26 Apr 2023, 8:48 pm Masahiko Sawada, <sawada(dot)mshk(at)gmail(dot)com <mailto:sawada(dot)mshk(at)gmail(dot)com>> wrote:
> It works but I think we might want to add the unit kB for
> understandability and consistency with other GUC_UNIT_KB parameters.
> I've attached a small patch that adds the unit and aligns the indent
> of the comments to the perimeter parameters.
>
> I'm not currently able to check, but if work_mem has a unit in the sample conf then I agree that vacuum_buffer_usage_limit should too.
+1 work_mem and all other related options in this section has a unit in the
sample conf so adding this makes sense.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-04-26 12:34:05 | Re: pg_stat_io for the startup process |
| Previous Message | Daniel Gustafsson | 2023-04-26 12:29:00 | Re: Find dangling membership roles in pg_dumpall |