| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |
| Date: | 2023-04-26 12:59:13 |
| Message-ID: | CAAKRu_Zbjj0=fAiuUZWwyLb8Wz+FhPj7N-p_CLkvSjbEeZL6Gw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 26, 2023 at 8:31 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 26 Apr 2023, at 13:26, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > On Wed, 26 Apr 2023, 8:48 pm Masahiko Sawada, <sawada(dot)mshk(at)gmail(dot)com
> <mailto:sawada(dot)mshk(at)gmail(dot)com>> wrote:
>
> > It works but I think we might want to add the unit kB for
> > understandability and consistency with other GUC_UNIT_KB parameters.
> > I've attached a small patch that adds the unit and aligns the indent
> > of the comments to the perimeter parameters.
> >
> > I'm not currently able to check, but if work_mem has a unit in the
> sample conf then I agree that vacuum_buffer_usage_limit should too.
>
> +1 work_mem and all other related options in this section has a unit in the
> sample conf so adding this makes sense.
>
Agreed.
for the patch, the other GUCs have a tab instead of a space between the
unit and the "#" of the first comment.
(not the fault of this patch but probably makes sense to fix now).
Otherwise, LGTM
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2023-04-26 13:00:08 | Re: [PATCH] Compression dictionaries for JSONB |
| Previous Message | Aleksander Alekseev | 2023-04-26 12:54:57 | Re: [PATCH] Infinite loop while acquiring new TOAST Oid |